Open
Conversation
根据响应状态码判断是否走重试机制
sutra
reviewed
Jan 6, 2022
| page = downloader.download(request, this); | ||
| } | ||
| if (page.isDownloadSuccess()){ | ||
| if (page.isDownloadSuccess()&&site.getAcceptStatCode().contains(page.getStatusCode())){ |
Author
There was a problem hiding this comment.
不是应该改 isDownloadSuccess 方法？
我感觉都可以
Author
There was a problem hiding this comment.
不是应该改 isDownloadSuccess 方法？
我只是把onDownloadSuccess中的判断提前到processRequest中了。如果修改isDownloadSuccess，就不能借助Site.acceptStatCode了，或者要改动的会更多一点。
Collaborator
There was a problem hiding this comment.
后面调用的 onDownloadSucess 里其实有 if (site.getAcceptStatCode().contains(page.getStatusCode())){ 感觉这整个逻辑有点乱。可以帮忙再多考虑一些。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
根据响应状态码判断是否走重试机制